[AVR] Remove workarounds for instructions using Z register (NFCI) #156361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 1, 2025
s-barannikov
force-pushed
the
users/s.barannikov/decoder-operands-2-riscv
branch
from
cc9f40c to
90b336f
Compare
s-barannikov
force-pushed
the
users/s.barannikov/decoder-operands-3-avr
branch
2 times, most recently
from
067f93e to
235b15d
Compare
s-barannikov
force-pushed
the
users/s.barannikov/decoder-operands-2-riscv
branch
2 times, most recently
from
9f30122 to
aa16f8a
Compare
s-barannikov
force-pushed
the
users/s.barannikov/decoder-operands-3-avr
branch
from
235b15d to
b1cd999
Compare
s-barannikov
force-pushed
the
users/s.barannikov/decoder-operands-2-riscv
branch
from
aa16f8a to
fd7e685
Compare
s-barannikov
force-pushed
the
users/s.barannikov/decoder-operands-3-avr
branch
2 times, most recently
from
6ff221b to
d3e77cd
Compare
s-barannikov
force-pushed
the
users/s.barannikov/decoder-operands-2-riscv
branch
from
fd7e685 to
4188fa4
Compare
s-barannikov
force-pushed
the
users/s.barannikov/decoder-operands-2-riscv
branch
from
4188fa4 to
d01399a
Compare
s-barannikov
force-pushed
the
users/s.barannikov/decoder-operands-3-avr
branch
2 times, most recently
from
1346d77 to
f88e35a
Compare
s-barannikov
force-pushed
the
users/s.barannikov/decoder-operands-2-riscv
branch
from
d01399a to
a85a8d9
Compare
benshi001
reviewed
Sep 4, 2025
|
It would be better to add an |
s-barannikov
changed the title
s-barannikov
force-pushed
the
users/s.barannikov/decoder-operands-2-riscv
branch
from
a85a8d9 to
de1f705
Compare
s-barannikov
force-pushed
the
users/s.barannikov/decoder-operands-3-avr
branch
from
f88e35a to
55e234b
Compare
s-barannikov
force-pushed
the
users/s.barannikov/decoder-operands-3-avr
branch
from
55e234b to
ff4fc23
Compare
s-barannikov
force-pushed
the
users/s.barannikov/decoder-operands-2-riscv
branch
from
de1f705 to
32e1a07
Compare
s-barannikov
force-pushed
the
users/s.barannikov/decoder-operands-3-avr
branch
from
ff4fc23 to
e488057
Compare
s-barannikov
force-pushed
the
users/s.barannikov/decoder-operands-2-riscv
branch
2 times, most recently
from
d19b8cd to
d564a29
Compare
s-barannikov
changed the base branch from
users/s.barannikov/decoder-operands-2-riscv
to
main
The generated disassembler can now correctly decode these instructions.
s-barannikov
force-pushed
the
users/s.barannikov/decoder-operands-3-avr
branch
from
e488057 to
15d65d9
Compare
s-barannikov
added a commit
that referenced
this pull request
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated disassembler can now correctly decode these instructions. All we need to do is to add
bits<0> zto their encodings and provide a decoder method that adds Z register to the instruction.